Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CRC64-NVME checksum algorithm #1235

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add support for CRC64-NVME checksum algorithm #1235

wants to merge 3 commits into from

Conversation

passaro
Copy link
Contributor

@passaro passaro commented Jan 17, 2025

This change adds support for the CRC64-NVME checksum algorithm when using relevant operations in mountpoint-s3-client and when appending to existing objects through Mountpoint (using --incremental-upload mode).

Does this change impact existing behavior?

No.

Does this change need a changelog entry? Does it require a version change?

Yes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@passaro
Upgrade test dependency to aws-sdk-s3 1.69
0f446d5 
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
@passaro passaro requested a deployment to PR integration tests January 17, 2025 10:16 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 10:16 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 10:16 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 10:16 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 10:16 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 10:16 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 10:16 — with GitHub Actions Waiting
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 10:18 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 10:18 — with GitHub Actions Inactive
@passaro passaro had a problem deploying to PR integration tests January 17, 2025 10:18 — with GitHub Actions Failure
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 10:18 — with GitHub Actions Inactive
@passaro passaro had a problem deploying to PR integration tests January 17, 2025 10:18 — with GitHub Actions Failure
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 10:18 — with GitHub Actions Inactive
@passaro passaro had a problem deploying to PR integration tests January 17, 2025 10:18 — with GitHub Actions Failure
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 11:31 — with GitHub Actions Inactive
@passaro passaro had a problem deploying to PR integration tests January 17, 2025 11:31 — with GitHub Actions Failure
@passaro passaro had a problem deploying to PR integration tests January 17, 2025 11:31 — with GitHub Actions Failure
@passaro passaro had a problem deploying to PR integration tests January 17, 2025 11:31 — with GitHub Actions Failure
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 11:31 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 11:31 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 11:31 — with GitHub Actions Inactive
@passaro
Add support for CRC64NVME
3e3c7a5 
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 14:22 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 14:22 — with GitHub Actions Inactive
@passaro passaro deployed to PR integration tests January 17, 2025 14:22 — with GitHub Actions Active
@passaro passaro had a problem deploying to PR integration tests January 17, 2025 14:22 — with GitHub Actions Failure
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 14:22 — with GitHub Actions Inactive
@passaro passaro had a problem deploying to PR integration tests January 17, 2025 14:22 — with GitHub Actions Failure
@passaro passaro temporarily deployed to PR integration tests January 17, 2025 14:22 — with GitHub Actions Inactive
@passaro passaro had a problem deploying to PR integration tests January 17, 2025 15:08 — with GitHub Actions Failure
@passaro
Add append test with crc64nvme
411a419 
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
@passaro passaro requested a deployment to PR integration tests January 17, 2025 18:19 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 18:19 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 18:19 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 18:19 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 18:19 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 18:19 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests January 17, 2025 18:19 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@passaro